-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support GCP cloud storage #17
base: main
Are you sure you want to change the base?
Conversation
I need help to test this in gcp. please let me know if you have access to it. I will have access to a gcp environment in a project that will use this code in a few weeks, I would appreciate if anyone could help me test it out before that. |
f110851
to
fa0df7b
Compare
Apart from my comment above, the only thing I noticed while testing this in a GCP Kubernetes cluster was, that the Dockerfile does not produce a working container. You are not copying the src/storage directory into the final runtime-image container and the storage_factory.py file is also missing, which makes the imports fail. opencost-parquet-exporter/Dockerfile Line 12 in fa0df7b
I would suggest replacing the copy directives to a single With these changes I managed to get a running container in a GCP cluster which was able to query the Opencost endpoint and upload the result to a GCS bucket using a Kubernetes service account with workload identity. I have not tested specifying OPENCOST_PARQUET_GCP_CREDENTIALS, neither have I tested using the default GOOGLE_APPLICATION_CREDENTIALS environment. I might get around to doing that at some later point but I cannot promise that. |
Update: Tested from a non-GCP cluster with OPENCOST_PARQUET_CREDENTIALS_JSON and it also works. |
@pvlkov thanks for testing and providing feedback. we fixed the docker error on the main branch. I am going to rebase this changes on it so the docker would be fixed. |
Thank you. |
This changes leverage the contribution by cklingspor, which added a storage factory and azure support to add support for gcp. This is a work in progress and need more testing.
Include the main requirements file instead of duplicating the versions inside requirements-dev.txt
fa0df7b
to
a1da04b
Compare
This changes leverage the contribution by cklingspor, which added a storage factory and azure support to add support for gcp.
This is a work in progress and need more testing.