Allow other forms of extra env variables to allow secrets #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should resolve opencost#209 Signed-off-by: Alexis Guerville <[email protected]>
mattray
approved these changes
Jul 31, 2024
Signed-off-by: Matt Ray <[email protected]>
|
I don't have cycles to test it, but the patch looks good. If someone else gives it a thumbs up I'll merge and release. |
toscott
reviewed
Aug 20, 2024
| @@ -64,7 +64,7 @@ $ helm install opencost opencost/opencost | |||
| | opencost.exporter.defaultClusterId | string | `"default-cluster"` | Default cluster ID to use if cluster_id is not set in Prometheus metrics. | | |||
| | opencost.exporter.env | list | `[]` | List of additional environment variables to set in the container | | |||
There was a problem hiding this comment.
Does this existing variable (env instead of extraEnv) not provide whats needed here?
There was a problem hiding this comment.
That's definitely a misread on my part, didn't realize there was two ways of adding environment variables, and since the "standard" is extraEnv in most helm charts, I didn't look further. Thanks!
| @@ -64,7 +64,7 @@ $ helm install opencost opencost/opencost | |||
| | opencost.exporter.defaultClusterId | string | `"default-cluster"` | Default cluster ID to use if cluster_id is not set in Prometheus metrics. | | |||
| | opencost.exporter.env | list | `[]` | List of additional environment variables to set in the container | | |||
| | opencost.exporter.extraArgs | list | `[]` | List of extra arguments for the command, e.g.: log-format=json | | |||
| | opencost.exporter.extraEnv | object | `{}` | Any extra environment variables you would like to pass on to the pod | | |||
| | opencost.exporter.extraEnv | list | `[]` | A list of extra environment variables you would like to pass on to the pod | | |||
There was a problem hiding this comment.
Swapping the type of object is backwards incompatible. For the sanity of downstream users, I recommend we keep breaking changes to only those absolutely required, and when we do we increment the chart major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve #209