Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: add unit tests #138

Merged
merged 4 commits into from
Oct 28, 2023
Merged

Proposal: add unit tests #138

merged 4 commits into from
Oct 28, 2023

Conversation

sntxrr
Copy link
Collaborator

@sntxrr sntxrr commented Oct 27, 2023

  • as part of my jobs internal rigor around helm, we require unit testing
  • thought it was worth proposing adding unit tests!

toscott
toscott approved these changes Oct 28, 2023
View reviewed changes
Copy link
Collaborator

@toscott toscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. Something we could get added to the build pipeline as well and cover all of the functions in _helpers as well.

@toscott toscott merged commit 0c7119d into opencost:main Oct 28, 2023
1 check passed
@sntxrr sntxrr deleted the unit-tests branch October 28, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toscott toscott toscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sntxrr @toscott