Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the pricing provider type #135

Merged

Conversation

toscott
Copy link
Collaborator

@toscott toscott commented Oct 25, 2023

What
Allow overriding the pricing provider type in the custom pricing configuration file.

Why
This allows us to provide the costModels for any provider directly through the configmap in the helm chart. For example, the aws provider and spot feed information could be configured with a values override that looks like this:

opencost:
  customPricing:
    enabled: true
    provider: aws    
    costModel:
      awsSpotDataRegion: us-east-2
      awsSpotDataBucket: my-spot-bucket
      awsSpotDataPrefix: spot_pricing_prefix

My hope is this simplifies Cost Model configuration for all providers by providing a straightforward path to configure it directly through the helm chart.

Copy link
Collaborator

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a pretty good approach going forward.

@mattray
Copy link
Collaborator

mattray commented Oct 27, 2023

You'll need to rebase and we should circle back on the documentation to add a section on custom pricing (beyond just on-prem).

@toscott toscott force-pushed the feature/expand-custom-pricing-options branch from e837264 to 9c81042 Compare October 28, 2023 14:38
@toscott toscott force-pushed the feature/expand-custom-pricing-options branch from 9c81042 to 79acf98 Compare October 28, 2023 14:52
@toscott toscott merged commit 2286bc5 into opencost:main Oct 28, 2023
1 check passed
@toscott toscott deleted the feature/expand-custom-pricing-options branch October 28, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants