-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial IPv6 support to RIB. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robshakir
commented
Nov 5, 2023
* (M) rib/rib(_test)?.go - Add support for IPv6 to RIB. * (M) constants/const.go - Add support for IPv6 constant.
* (M) rib/rib(_test)?.go - Add support for generating IPv6 protobufs from a RIB entry.
* (M) rib/rib(_test)?.go - Add checks for IPv6 and MPLS entries successfully calling the post change hooks in the RIB.
* (M) rib/rib(_test)?.go - Add support for checking whether IPv6 entries can be resolved to the RIB and associated testing.
* (M) rib/rib(_test)?.go - Add support for IPv6Entries in `Get` operations on the RIB.
* (M) rib/rib(_test).go - Add support for checking whether IPv6 entries can be deleted from the RIB. - Add testing for `resolvedEntryHook` for IPv6 entries.
* (M) rib/rib.go - Add support for `Flush` calls to remove IPv6 entries. * (M) rib/rib_test.go - Ensure that test coverage exists for both MPLS and IPv6 for Flush.
* (M) go.{mod,sum} - Upgrade to non-release version of ygot to fix bug with parsing of pushed label stacks. * (M) server/server(_test)?.go - Add support and testing for IPv6 into server.
* (M) fluent/fluent.go - Add IPv6 entry support within the gRIBIgo fluent library. * (M) fluent/fluent_test.go - Add testing for IPv6 builder, and additional coverage for MPLS.
* (M) client/gribiclient(_test)?.go - Add support within the client library for IPv6 and MPLS where required, and test coverage for the client. * (M) fluent/fluent.go - Add support for IPv6 within fluent library. * (M) compliance/compliance.go - Add test cases for basic IPv6 functionality.
Oops -- this is the base PR for all the changes already reviewed. @alshabib - you've reviewed all code contained in here, I just forgot to get approval on this one for the final merge. D'oh. |
alshabib
approved these changes
Nov 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.