Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FakeRIB for testing. #195

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Add FakeRIB for testing. #195

merged 3 commits into from
Oct 17, 2023

Conversation

robshakir
Copy link
Contributor 

commit 5dd69e446694f1fd44f029ff74a2782c6cf1886d
Author: Rob Shakir <[email protected]>
Date:   Thu Sep 21 21:52:24 2023 +0000

    Add a `FakeRIB` to simplify testing.
    
     * (M) rib/helpers(_test).go
       - Add helper methods for a RIB that allow it to be constructed
         for tests in a simpler fashion.

@robshakir
Add a FakeRIB to simplify testing.
5dd69e4 
 * (M) rib/helpers(_test).go
   - Add helper methods for a RIB that allow it to be constructed
     for tests in a simpler fashion.
@robshakir robshakir changed the base branch from main to reconciler September 21, 2023 21:53
@robshakir
Add support for retreiving from a remote RIB. (#196)
3905544 
    Add support for retrieving a RIB from a remote source.
    
     * (M) go.{mod,sum}
      - Move to non-release version of ygot to get new `protomap` features.
     * (M) rib/remote.go
      - Add support for a RIB that is accessed via the `Get` RPC rather than
        locally.
     * (M) rib/rib(_test).go
      - Add a mechanism to retrieve RIB contents, improve testing.
@robshakir robshakir merged commit 98e2bf4 into reconciler Oct 17, 2023
5 checks passed
@robshakir robshakir deleted the reconciler1 branch October 17, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alshabib alshabib alshabib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robshakir @alshabib