Skip to content

Refactor RIB to fix reference counting. #1162

Refactor RIB to fix reference counting.

Refactor RIB to fix reference counting. #1162

Triggered via pull request November 14, 2023 20:45
@robshakirrobshakir
synchronize #219
debug
Status Failure
Total duration 7m 13s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

go.yml

on: pull_request
Matrix: go / Build and Test
Fit to window
Zoom out
Zoom in

Annotations

11 errors
go / Static Analysis
Process completed with exit code 1.
go / Static Analysis: constants/const.go#L15
package comment should be of the form "Package constants ..."
go / Static Analysis: testcommon/testcommon.go#L34
comment on exported type TLSCred should be of the form "TLSCred ..." (with optional leading article)
go / Static Analysis: fluent/fluent.go#L307
exported const AllAFTs should have comment (or a comment on this block) or be unexported
go / Static Analysis: fluent/fluent.go#L1066
comment on exported const UnsupportedParameters should be of the form "UnsupportedParameters ..."
go / Static Analysis: fluent/fluent.go#L1071
comment on exported const ParamsDifferFromOtherClients should be of the form "ParamsDifferFromOtherClients ..."
go / Static Analysis: fluent/fluent.go#L86
exported method Connection returns unexported type *fluent.gRIBIConnection, which can be annoying to use
go / Static Analysis: fluent/fluent.go#L278
exported method Get returns unexported type *fluent.gRIBIGet, which can be annoying to use
go / Static Analysis: fluent/fluent.go#L353
exported method Flush returns unexported type *fluent.gRIBIFlush, which can be annoying to use
go / Static Analysis: fluent/fluent.go#L406
exported method Modify returns unexported type *fluent.gRIBIModify, which can be annoying to use
go / Static Analysis: fluent/fluent.go#L533
exported func IPv4Entry returns unexported type *fluent.ipv4Entry, which can be annoying to use