Refactor RIB to fix reference counting. #1161
robshakir
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
go.yml
on: pull_request
go
/
Static Analysis
3m 40s
go
/
staticcheck
38s
Matrix: go / Build and Test
Annotations
15 errors
|
go / Build and Test (oldstable)
Process completed with exit code 1.
|
|
go / Static Analysis
The run was canceled by @robshakir.
|
|
go / Static Analysis
The operation was canceled.
|
|
go / Static Analysis:
constants/const.go#L15
package comment should be of the form "Package constants ..."
|
|
go / Static Analysis:
testcommon/testcommon.go#L34
comment on exported type TLSCred should be of the form "TLSCred ..." (with optional leading article)
|
|
go / Static Analysis:
server/server.go#L144
exported func WithPostChangeRIBHook returns unexported type *server.postChangeRibHook, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L169
exported func WithRIBResolvedEntryHook returns unexported type *server.resolvedEntryHook, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L196
exported func DisableRIBCheckFn returns unexported type *server.disableCheckFn, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L218
exported func WithVRFs returns unexported type *server.withVRFs, which can be annoying to use
|
|
go / Static Analysis:
server/server.go#L138
type name will be used as server.ServerOpt by other packages, and that stutters; consider calling this Opt
|
|
go / Static Analysis:
server/server.go#L167
comment on exported function WithRIBResolvedEntryHook should be of the form "WithRIBResolvedEntryHook ..."
|
|
go / Static Analysis:
server/server.go#L412
parameter 'ctx' seems to be unused, consider removing or renaming it as _
|
|
go / Static Analysis:
fluent/fluent.go#L86
exported method Connection returns unexported type *fluent.gRIBIConnection, which can be annoying to use
|
|
go / Build and Test (stable)
The run was canceled by @robshakir.
|
|
go / Build and Test (stable)
The operation was canceled.
|