Add support for NH diff; refactor return type. #1095
robshakirgo.yml
on: pull_request
go
/
Static Analysis
4m 40s
go
/
staticcheck
49s
Matrix: go / Build and Test
Annotations
10 errors
|
go / Static Analysis:
fluent/fluent.go#L307
exported const AllAFTs should have comment (or a comment on this block) or be unexported
|
|
go / Static Analysis:
fluent/fluent.go#L975
comment on exported const UnsupportedParameters should be of the form "UnsupportedParameters ..."
|
|
go / Static Analysis:
fluent/fluent.go#L980
comment on exported const ParamsDifferFromOtherClients should be of the form "ParamsDifferFromOtherClients ..."
|
|
go / Static Analysis:
server/server.go#L138
type name will be used as server.ServerOpt by other packages, and that stutters; consider calling this Opt
|
|
go / Static Analysis:
server/server.go#L167
comment on exported function WithRIBResolvedEntryHook should be of the form "WithRIBResolvedEntryHook ..."
|
|
go / Static Analysis:
rib/reconciler/reconcile.go#L37
exported type R should have comment or be unexported
|
|
go / Static Analysis:
constants/const.go#L15
package comment should be of the form "Package constants ..."
|
|
go / Static Analysis:
client/gribiclient.go#L1098
type name will be used as client.ClientStatus by other packages, and that stutters; consider calling this Status
|
|
go / Static Analysis:
client/gribiclient.go#L1151
comment on exported type ClientErr should be of the form "ClientErr ..." (with optional leading article)
|
|
go / Static Analysis:
rib/rib.go#L52
type name will be used as rib.RIBHookFn by other packages, and that stutters; consider calling this HookFn
|