chore: enable fail on warning #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we need to figure out what to do with sorrys |
|
Asked on Lean zulip about suppressing sorrys: https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/suppress.20sorry.20warnings/near/437970722 |
|
We only have two sorries left in proofs that we may not need. Should we just drop them and replace them with |
|
@tobiasgrosser that's a good idea, would you mind making the change? |
I replaced the first: #363. Not sure what about the second one. Should we comment that one? |
|
I commented the last sorry. Let's see if that makes this PR green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This forces us to fix all warnings.