Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/61-property-panel-open #62

Merged
merged 3 commits into from
May 8, 2024
Merged

fix/61-property-panel-open #62

merged 3 commits into from
May 8, 2024

Conversation

pogi7
Copy link
Member

@pogi7 pogi7 commented May 6, 2024

Checklist before submitting a merge request

Description of contribution

open property panel immediately when showProperties command is called
closes #61

Testing performed

  • I have added unit tests to cover additional functionality

How to Test Expected functionality changes

[Describe expected behaviour changes in steps]

  1. Go to https://github.com/pogi7/kepler16b-example
  2. Switch to main branch
  3. Run git pull
  4. From the command line run ./gradlew load
  5. Wait for that command to finish
  6. Open the Objectives webview
  7. Double Click on any row
  8. Verify that the OML Vision Properties panel renders immediately with data

Additional context

[If needed, you may add additional context]

@pogi7 pogi7 requested review from greypilgrim and aematei May 6, 2024 16:27
@pogi7 pogi7 self-assigned this May 7, 2024
@pogi7 pogi7 requested a review from UTNAK May 8, 2024 23:14
Copy link
Collaborator

@UTNAK UTNAK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the property panels using the codespace.

@UTNAK UTNAK merged commit a8025cd into master May 8, 2024
@UTNAK UTNAK deleted the fix/61-property-panel-open branch May 8, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property Panel does not immediately open when clicking a row or node
2 participants