Create insert panel for inserting instances and relations #48
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import React, { ReactElement } from "react"; | ||
|
|
||
| interface InsertItemProps { | ||
| label: string; | ||
| onItemClicked: () => void; | ||
| icon: ReactElement<any>; | ||
| } | ||
|
|
||
| const InsertItem: React.FC<InsertItemProps> = ({ label, onItemClicked, icon }) => { | ||
| return ( | ||
| <div onClick={ onItemClicked } className="flex flex-row"> | ||
| <span className="text-[10px]">{ label }</span> | ||
| { icon } | ||
| </div> | ||
| ) | ||
| } | ||
|
|
||
| interface InsertPanelProps { | ||
| components: InsertItemProps[]; | ||
| relationships: InsertItemProps[]; | ||
| } | ||
|
|
||
| const InsertPanel: React.FC<InsertPanelProps> = ({ components, relationships }) => { | ||
| return ( | ||
| <div className="flex flex-col {`z-10 p-2 space-y-2 rounded shadow-md bg-[var(--vscode-banner-background)] overflow-y-auto max-h-[9rem]`}"> | ||
| <span className="font-bold">Components</span> | ||
| <div className="pl-4 border-solid border-2 "> | ||
| {components.map((component, index) => ( | ||
| <InsertItem | ||
| label={component.label} | ||
| onItemClicked={component.onItemClicked} | ||
| icon={component.icon} /> | ||
| ))} | ||
| </div> | ||
| <span className="">Relationships</span> | ||
| {relationships.map((relationship, index) => ( | ||
| <InsertItem | ||
| label={relationship.label} | ||
| onItemClicked={relationship.onItemClicked} | ||
| icon={relationship.icon} /> | ||
| ))} | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| export default InsertPanel; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { ReactElement } from "react" | ||
|
|
||
| export type InsertItem = { | ||
| label: string, | ||
| onItemClicked: () => void, | ||
|
There was a problem hiding this comment. @aematei Please refer to my earlier comment regarding the arrow function |
||
| icon: ReactElement<any> | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aematei You may want to have a function called
handleItemClicked. The code will be more reusable than arrow functions. This arrow function is anonymous so it may be hard to call the logic within the function in another part of the app.Look at the official Typescript documentation and this Stack Overflow post for more details:
https://www.typescriptlang.org/docs/handbook/interfaces.html#function-types
https://stackoverflow.com/questions/45721344/arrow-function-in-typescript-interface-with-return-type-as-void
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pogi7 should I still include the function in the interface/type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aematei Yes. It would look like
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh got it! That makes sense, thanks.