Remove mlock #29
Open
Remove mlock #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`mlock` has been removed from openbao since v2.0.0. This fixes a warning in the bao server logs when deploying via helm. Signed-off-by: Lewis Middleton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a warning in the bao server logs when deploying via helm.
mlockwas proposed for removal in themlockremoval RFC and merged in openbao/openbao#363 which was first released in v2.0.0The
disable_mlockconfig option is currently hardcoded into the helm chart.This leads to a warning in the openbao server logs when deploying via the helm chart:
{"@level":"warn","@message":"unknown or unsupported field disable_mlock found in configuration at /tmp/storageconfig.hcl:2:1","@timestamp":"2024-12-30T15:50:01.935705Z"}