Update GUI install instructions #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlecVercruysse
commented
Jul 1, 2020
AlecVercruysse
commented
- fix 404 errors relating to a moved SCRIPTS/ folder
- remove --user flag from pip install instructions since a venv should be activated
- fix typo in script chmod command
- update WORKING_DIR variable in scripts
- fix 404 errors relating to a moved SCRIPTS/ folder - remove --user flag from pip install instructions since a venv should be activated - fix typo in script chmod command
- this pointed to a hard-coded link that was now broken. - this line from s/o: https://stackoverflow.com/questions/59895/how-to-get-the-source-directory-of-a-bash-script-from-within-the-script-itself worked for my limited testing.-
|
fixes #13 |
renerichter
suggested changes
Jul 3, 2020
| WORKING_DIR="${USER_HOME_DIR}/UC2/SCRIPTS" | ||
| WORKING_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" |
There was a problem hiding this comment.
you assume that script will be run from within the containing folder. That not necessarily is typically the case... or?
There was a problem hiding this comment.
Good point. We can avoid any issues with the user using a different directory structure/running from a different dir by just evaluating pwd.
AlecVercruysse
commented
Jul 3, 2020
| WORKING_DIR="${USER_HOME_DIR}/UC2/SCRIPTS" | ||
| WORKING_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )" |
There was a problem hiding this comment.
Good point. We can avoid any issues with the user using a different directory structure/running from a different dir by just evaluating pwd.
install into active instead of prenamed directory Co-authored-by: Alec <[email protected]>
renerichter
approved these changes
Jul 3, 2020
|
Dear Alec,
due to some internal problems regarding interfacing GITHUB some
non-necessary commits were done and the commit-registry was scrumbled.
Hence, I ended up force-pushing my local-state over origin:MASTER which
accidentally led to your pull-requests (and merge) not being included
anymore. Now I wonder: Do you have an elegant idea how we can avoid as many
reverting and cherry-picking as possible and just get your PUSH easily in
there again?
Sorry for the inconvenience.
Best regards
René
Am Fr., 3. Juli 2020 um 09:25 Uhr schrieb Alec <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In GUI/RASPBERRY_PI/SCRIPTS/SETUP_UC2env/00-UC2_Prerequisites.sh
<#14 (comment)>
:
> @@ -2,6 +2,6 @@
echo [UC2] Loading variables...
USER_HOME_DIR="/home/$USER"
-WORKING_DIR="${USER_HOME_DIR}/UC2/SCRIPTS"
+WORKING_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
⬇️ Suggested change
-WORKING_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
+WORKING_DIR="$(pwd)"
------------------------------
In GUI/RASPBERRY_PI/SCRIPTS/SETUP_UC2env/00-UC2_Prerequisites.sh
<#14 (comment)>
:
> -WORKING_DIR="${USER_HOME_DIR}/UC2/SCRIPTS"
+WORKING_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
Good point. We can avoid any issues with the user using a different
directory structure/running from a different dir by just evaluating pwd.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXLFM6OPRLGNCREFI6E3CLRZWBYJANCNFSM4ON5JZVQ>
.
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Phd-stud. René Lachmann
R182, FA8, Biomedical Imaging
Leibniz Institute of Photonic Technology,
Albert-Einstein Str. 9, 07745 Jena, Germany
Tel.: +49 (0) 3641 206 426
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
I get a 442 server error when I try to resubmit my PR, even though github says the branches can merge automatically. I've filed a support ticket for now. If they say it is not possible due to the forced changes in history, I will just quickly rewrite them. |
|
Thank you for your efforts!
Any response already? :)
2020年7月16日(木) 21:38 Alec <[email protected]>:
… I get a 442 server error when I try to resubmit my PR, even though github
says the branches can merge automatically. I've filed a support ticket for
now. If they say it is not possible due to the forced changes in history, I
will just quickly rewrite them.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXLFM4UXTMGGQ6ITC5M3FLR35JMZANCNFSM4ON5JZVQ>
.
|
|
Sorry for the problems which came up by merging using the github desktop
thingy. I'll push everything to the devBD branch for now. My fault.
|
|
Any changes regarding the topic?
Am Do., 16. Juli 2020 um 21:38 Uhr schrieb Alec <[email protected]>:
… I get a 442 server error when I try to resubmit my PR, even though github
says the branches can merge automatically. I've filed a support ticket for
now. If they say it is not possible due to the forced changes in history, I
will just quickly rewrite them.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXLFM4UXTMGGQ6ITC5M3FLR35JMZANCNFSM4ON5JZVQ>
.
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Phd-stud. René Lachmann
R182, FA8, Biomedical Imaging
Leibniz Institute of Photonic Technology,
Albert-Einstein Str. 9, 07745 Jena, Germany
Tel.: +49 (0) 3641 206 426
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
No comments on the ticket, but I tried again just for a last ditch attempt and it worked! #15. |
|
Very nice!
Thank you for your help in this issue!
Am Mo., 20. Juli 2020 um 18:17 Uhr schrieb Alec <[email protected]>:
… No comments on the ticket, but I tried again just for a last ditch attempt
and it worked! #15
<#15>.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXLFMZYVMMUDNBB74QRYODR4RUYRANCNFSM4ON5JZVQ>
.
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
René Richter
R184, FA8-2, Biomedical Imaging
Leibniz Institute of Photonic Technology,
Albert-Einstein Str. 9, 07745 Jena, Germany
Tel.: +49 (0) 3641 206 303
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.