-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed python discovery using more modern CMake functions. #356
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want to ship Python 2 stuff at all anymore?
I am happy to drop it. I have not been using python 2 since 2013. But since python 2 support is already in the repo, I have implemented it too. |
2393e57
to
7431a13
Compare
7431a13
to
93f89f7
Compare
Where's the "fixed discovery"? The commit is just doing things different, but I don't see what it tries to fix. |
Now I don't remember all the details what the issues were, but was is related to python 2 being used somewhere where python 3 must have been used (in |
93f89f7
to
859ac92
Compare
…ke they are bundled and backported. For newer CMake the ones shipped with CMake are used.
859ac92
to
3bcb0fb
Compare
For old CMake they are bundled and backported. For newer CMake the ones shipped with CMake are used.