Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Potentially unsafe external link detected by CodeQL #3525

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fixes Potentially unsafe external link detected by CodeQL #3525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/views/clients/viewclient.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1173,7 +1173,7 @@ <h4><strong>{{client.displayName}}</strong></h4>
<td>
<span ng-repeat="file in document.documents">
{{file.fileName}}&nbsp;&nbsp;
<a target="_blank" href="{{hostUrl}}{{file.docUrl}}" has-permission='READ_DOCUMENT'><i
<a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{file.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a>
</span>
</td>
Expand Down Expand Up @@ -1214,7 +1214,7 @@ <h4><strong>{{client.displayName}}</strong></h4>
<td>{{clientdocument.description}}</td>
<td>{{clientdocument.fileName}}</td>
<td>
<a target="_blank" href="{{hostUrl}}{{clientdocument.docUrl}}"><i class="fa fa-cloud-download"></i></a>&nbsp;
<a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{clientdocument.docUrl}}"><i class="fa fa-cloud-download"></i></a>&nbsp;
<a ng-show="clientdocument.fileIsImage" ng-click="previewDocument(clientdocument.docUrl,clientdocument.fileName)"><i class="fa fa-eye"></i></a>
<a ng-click="deleteDocument(clientdocument.id,$index)"><i class="fa fa-times"></i></a>
</td>
Expand Down
2 changes: 1 addition & 1 deletion app/views/loans/viewloanaccountdetails.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,7 +892,7 @@ <h3>{{'label.heading.currentBalance' | translate}}: {{loandetails.currency.displ
<td>{{document.description}}</td>
<td>{{document.fileName}}</td>
<td>
<a target="_blank" href="{{hostUrl}}{{document.docUrl}}"><i class="fa fa-cloud-download"></i></a>&nbsp;
<a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{document.docUrl}}"><i class="fa fa-cloud-download"></i></a>&nbsp;
<a ng-show="document.fileIsImage" ng-click="previewDocument(document.docUrl,document.fileName)"><i class="fa fa-eye"></i></a>
<a ng-click="deleteDocument(document.id,$index)"><i class="fa fa-times"></i></a>
</td>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportcenters.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h3 class="panel-title">{{'label.input.centertemplate' | translate}}</h3>
<option value="">--{{'label.menu.selectloanofficer' | translate}}--</option>
</select>
</div>
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CENTERS'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CENTERS'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -90,7 +90,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportclients.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ <h3 class="panel-title">{{'label.input.clienttemplate' | translate}}</h3>
</select>
</div>
<div class="col-xs-1">
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</div>
Expand Down Expand Up @@ -105,7 +105,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportcoa.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h3 class="panel-title">{{'label.input.chartofaccountstemplate' | translate}}</h
<option value="">--{{'label.menu.selectloanofficer' | translate}}--</option>
</select>
</div>
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -90,7 +90,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportemployees.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h3 class="panel-title">{{'label.input.employeetemplate' | translate}}</h3>
</select>
</div>
</div> &nbsp; &nbsp; &nbsp;
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportfixeddepositaccounts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h3 class="panel-title">{{'label.input.fdaccountstemplate' | translate}}</h3>
<option value="">--{{'label.menu.selectloanofficer' | translate}}--</option>
</select>
</div>
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -90,7 +90,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportfixeddeposittransactions.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h3 class="panel-title">{{'label.input.fdtransactionstemplate' | translate}}</h3
</select>
</div>
</div> &nbsp; &nbsp; &nbsp;
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportgroup.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h3 class="panel-title">{{'label.input.grouptemplate' | translate}}</h3>
<option value="">--{{'label.menu.selectloanofficer' | translate}}--</option>
</select>
</div>
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -91,7 +91,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportguarantor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h3 class="panel-title">{{'label.input.guarantortemplate' | translate}}</h3>
</select>
</div>
</div> &nbsp; &nbsp; &nbsp;
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportjournalentries.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h3 class="panel-title">{{'label.input.journalentriestemplate' | translate}}</h3
</select>
</div>
</div> &nbsp; &nbsp; &nbsp;
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportloanaccounts.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ <h3 class="panel-title">{{'label.input.loanaccounttemplate' | translate}}</h3>
<option value="">--{{'label.menu.selectloanofficer' | translate}}--</option>
</select>
</div>
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -91,7 +91,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportloanrepayments.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ <h3 class="panel-title">{{'label.input.loanrepaymenttemplate' | translate}}</h3>
</select>
</div>
</div> &nbsp; &nbsp; &nbsp;
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
<a target="_blank" rel="noopener noreferrer" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}{{first.queryParams}}" has-permission='READ_CLIENT'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</div>
</form>
Expand Down Expand Up @@ -82,7 +82,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
4 changes: 2 additions & 2 deletions app/views/organization/bulkimport/bulkimportoffices.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ <h3 class="panel-title">{{'label.input.officetemplate' | translate}}</h3>
<div class="panel-body">
<div class="form-group">
<form name="bulkImportOffices" class="form-inline" role="form">
<a target="_blank" class='btn btn-primary' href="{{hostUrl}}{{first.templateUrl}}" has-permission='READ_OFFICE'><i
<a target="_blank" class='btn btn-primary' rel="noopener noreferrer" href="{{hostUrl}}{{first.templateUrl}}" has-permission='READ_OFFICE'><i
class="fa fa-cloud-download"></i>{{'label.button.download' | translate}}</a>
</form>
</div>
Expand Down Expand Up @@ -69,7 +69,7 @@ <h3 class="panel-title">{{'label.heading.documents' | translate}}</h3>
<td>{{import.totalRecords}}</td>
<td>{{import.successCount}}</td>
<td>{{import.failureCount}}</td>
<td ng-show='import.completed'><a target="_blank" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
<td ng-show='import.completed'><a target="_blank" rel="noopener noreferrer" href="{{hostUrl}}{{import.docUrl}}" has-permission='READ_DOCUMENT'><i
class="fa fa-cloud-download"></i></a></td>

</tr>
Expand Down
Loading