Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional variables from GENeSYS-MOD for openTEPES and Plan4EU #105

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tburandt
Copy link
Contributor

@tburandt tburandt commented Mar 2, 2021

Additional/changed variables after requests from @erikfilias and @sandrinecharousset

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tburandt - see a few comments inline

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tburandt for these changes - I tried to resolve the merge conflicts to save you some time, please review and write a comment when it's good to merge.

One observation: @erikfilias changed the units from GW (only) to allow both MW and GW - maybe also relevant in this PR for consistency?

@danielhuppmann
Copy link
Member

@tburandt @loeffko, this PR has not been active for a year - please review whether the proposed changes are still relevant.

If yes, please resolve the merge conflicts or start a new branch and PR with the relevant changes. Then, close this PR.

@sandrinecharousset
Copy link
Collaborator

@tburandt @loeffko, this PR has not been active for a year - please review whether the proposed changes are still relevant.

If yes, please resolve the merge conflicts or start a new branch and PR with the relevant changes. Then, close this PR.

@danielhuppmann @loeffko @tburandt it appears that except maybe for the emissions.yaml file, all other changes are already included in the master or in more recent PRs. I would suggest you review the changes in emissions.yaml and create a new PR if necessary, and close this one.....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants