-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard handler rewrite #332
base: master
Are you sure you want to change the base?
Keyboard handler rewrite #332
Conversation
…r can add new ones - might change this
…now remove previous assignments from the grid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try {} catch {} or atoi
for avoiding C++ exception throwing. Elegant solution (much more so than my "i'm learning C++ so duplicating code everywhere" approach :)
…c to cancel is now communicated to the user
…dability of the code
The above comments should all be resolved. I also did a bit of a refactor of the hotkey dialog box as it was a bit messy before. I fixed some bugs i noticed along the way also. Such as not allowing SHIFT and ESC to be set as a hotkey. Since SHIFT is the inverse of an action, it caused some very confusing behavior if allowed to be set as a hotkey as well. I also changed the format of hotkey dialog on the front end to try to communicate some of this to the user here is what it looks like now: |
I rewrote how LUPPP handles the keyboard shortcuts. This pull request adds a new context menu button when right clicking on a clip. It shows the current hotkey assigned to this clip and allows the user to change it with a single button press. If another hotkey is already assigned somewhere else it will remove that assignment applying it to only the current clip in context.
Heres what it looks like:
This addresses quite a few problems from the previous implementation. One thing was that the hotkeys are not communicated in any way to the user and when first using LUPPP it was a little confusing, especially when not using a US/UK qwerty keyboard.
Hotkeys are saved to the luppp.prfs file and it now auto saves the prfs on exit.
As it stands in this PR the new hotkeys are only set for that instance of the application. I want this to persist from one luppp launch to the other andI would like to make the other special keys configurable too in thesetup
menu. To prevent this branch from ballooning too much I think I'm at a point where its good enough to merge.