Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add midi beat event #313

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

wvengen
Copy link
Contributor

@wvengen wvengen commented Jun 22, 2020

Implements #124.
Depends on PR #311, for this PR only the last commit here is relevant.

See also #124 (comment) for usage.

  • Fix event queueing

src/timemanager.cxx Outdated Show resolved Hide resolved
@wvengen
Copy link
Contributor Author

wvengen commented Nov 9, 2020

Thanks for your feedback and explanation! I'll change the ringbuffer issue you mentioned, will try to do so this year still.

Copy link
Member

@harryhaaren harryhaaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wvengen, reviewed these changes, they look good to me but I have not tested them. Any last comments, or are you OK with me clicking the big green MERGE?

@wvengen
Copy link
Contributor Author

wvengen commented May 31, 2024

It's been a while, and I don't remember how thoroughly I tested it. Did some tests now (~10m), with the midi beat event and a midi monitor, some playing around, and midi input. All seems to work fine. I would be confident pressing MERGE (though for a production release, I would expect that someone else than me would also test it, but that could also be users and releasing another version if unexpected bugs come up; the code is straightforward enough that I don't really expect this though).
Thanks for keeping up maintenance on this project now and then :)

@wvengen
Copy link
Contributor Author

wvengen commented May 31, 2024

Ah, actually there is one open question in PR #311 (note that this PR depends on it).
If you are happy with dataList, please go ahead. If not, then we should not yet merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants