-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IBAL files #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few comments to leave or take...
- Rename files to
nist-example
to align with LBNL and NREL? - Rename
nist-example.md
header 1 toNIST Example Building
to follow the others? - Move
examples/nist-example
up in TOC to alphabetize.
@MatthewSteen Renamed the file to nist-example and changed everything else accordingly so its more in line with LBNL and NREL. Do I need to run make_model_formats.py? Otherwise, I think this is fine. |
No, that's run in the book.yml action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Updated IBAL schematic and turtle file in preparation for Friday as of December 20. I can also update the .md file as well as I was not sure if that is something I need to manually update the instances of.