Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IBAL files #6

Merged
merged 9 commits into from
Dec 21, 2023
Merged

Update IBAL files #6

merged 9 commits into from
Dec 21, 2023

Conversation

BradEstacio
Copy link
Collaborator

Updated IBAL schematic and turtle file in preparation for Friday as of December 20. I can also update the .md file as well as I was not sure if that is something I need to manually update the instances of.

Copy link
Contributor

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments to leave or take...

  1. Rename files to nist-example to align with LBNL and NREL?
  2. Rename nist-example.md header 1 to NIST Example Building to follow the others?
  3. Move examples/nist-example up in TOC to alphabetize.

@BradEstacio
Copy link
Collaborator Author

@MatthewSteen Renamed the file to nist-example and changed everything else accordingly so its more in line with LBNL and NREL. Do I need to run make_model_formats.py? Otherwise, I think this is fine.

examples/nist-ibal.md Outdated Show resolved Hide resolved
@MatthewSteen
Copy link
Contributor

@MatthewSteen Renamed the file to nist-example and changed everything else accordingly so its more in line with LBNL and NREL. Do I need to run make_model_formats.py? Otherwise, I think this is fine.

No, that's run in the book.yml action.

Copy link
Contributor

@MatthewSteen MatthewSteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatthewSteen MatthewSteen merged commit b8950e7 into main Dec 21, 2023
1 check passed
@MatthewSteen MatthewSteen deleted the ibal-update branch December 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants