Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add G36 4.2 #1

Merged
merged 5 commits into from
Dec 15, 2023
Merged

add G36 4.2 #1

merged 5 commits into from
Dec 15, 2023

Conversation

MatthewSteen
Copy link
Contributor

For Docs Tutorial 1. FYI @lazlop.

@gtfierro
Copy link
Contributor

I just pushed a README file describing how to add a model to this repository. Committing the file to the models/ directory will be enough to present it online under "https://models.open223.info/.ttl"

@MatthewSteen
Copy link
Contributor Author

@gtfierro great, I'll work on finishing this then. A couple questions...

  1. Naming Convention
    1. same as 223 GitLAB?
    2. guideline36-2021-4.2.ttl?
    3. ?
  2. Folders. Should we organize into...
    • ashrae/
    • lbnl/
    • nrel/

@gtfierro
Copy link
Contributor

@gtfierro great, I'll work on finishing this then. A couple questions...

  1. Naming Convention

    1. same as 223 GitLAB?

The code here is agnostic to the naming convention. As long as the file names match across the different components (.md, .ttl, etc), we are good to go. Let me know if you hit any bugs or unexpected behavior. The GitHub Action should take care of all the builds so you don't need to run this locally

  1. guideline36-2021-4.2.ttl?

  2. ?

  3. Folders. Should we organize into...

    • ashrae/
    • lbnl/
    • nrel/

We can, but this might be more organization than we need yet. I think differentiating between building/system is enough for now. The source of the example probably doesn't matter as much

@MatthewSteen
Copy link
Contributor Author

@gtfierro ready. Note I changed the book.yml file to run on PRs too. It probably shouldn't deploy (if statement) just successfully run jb build ..

@gtfierro
Copy link
Contributor

Good change! Thanks for handling that

@gtfierro gtfierro merged commit 72cc144 into main Dec 15, 2023
1 check passed
@MatthewSteen MatthewSteen deleted the add/g36-4.2 branch December 15, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants