Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes based on @hugo-ter-doest's comments on #3 #5

Merged
merged 4 commits into from
Apr 16, 2020
Merged

Fixes based on @hugo-ter-doest's comments on #3 #5

merged 4 commits into from
Apr 16, 2020

Conversation

ElenaFdR
Copy link
Collaborator

@ElenaFdR ElenaFdR commented Apr 15, 2020 •
edited
Loading

I've created this as a draft PR while I work through @Hugo-ter-Doest's comments.

Still to do:
- [ ] standardize jullie vs uw throughout the document (logged as #8)

  • substantive changes in governance doc (in both Dutch and English)

@ElenaFdR ElenaFdR mentioned this pull request Apr 15, 2020
Merged
@ElenaFdR ElenaFdR marked this pull request as ready for review April 16, 2020 08:26
@ElenaFdR ElenaFdR requested a review from Ainali April 16, 2020 08:34
Ainali
Ainali approved these changes Apr 16, 2020
View reviewed changes
Copy link
Collaborator

@Ainali Ainali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only reviewed the changes in English, but those looked all good to me

@clausmullie
Copy link
Collaborator

Checked the Dutch parts, looks good!

@clausmullie clausmullie merged commit 0706edd into develop Apr 16, 2020
@clausmullie clausmullie deleted the Hugo-review-comments branch April 16, 2020 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausmullie clausmullie clausmullie left review comments

@Hugo-ter-Doest Hugo-ter-Doest Hugo-ter-Doest left review comments

@Ainali Ainali Ainali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElenaFdR @clausmullie @Ainali @Hugo-ter-Doest