-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔖 Release 1.8.0 #220
base: main
Are you sure you want to change the base?
🔖 Release 1.8.0 #220
Conversation
23abd73
to
12ebc64
Compare
12ebc64
to
204c800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The New Features heading should be first like the other versions plus some other commends about the layout.
Some hidden changes missing from the change log.
Updated django setup configuration from 0.2.0 to 0.4.0+, so the old setup configuration will not work. If there were any old step, it should be mention that they no longer work and are gone if they have not been replaced.
* [#199] Add Admin OIDC Configuration step from django-setup-configuration | ||
* [#204] Add SitesConfiguration Step from django-setup-configuration | ||
* [#200] Autorisaties-API configuration via django-setup-configuration | ||
* [#202] Configuration Kanalen via django-setup-configuration | ||
* [#202] Configuration Abonnementen via django-setup-configuration | ||
* [#203] Configuration Notification settings via django-setup-configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would consider these new features
@@ -15,6 +21,29 @@ Changes | |||
was added to move to the `Service` model. It is advised to verify the `Service` | |||
instances in the admin to check that the data migration was ran as expected. | |||
|
|||
**New features** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New features should be first (then bugfixes)
I also noticed that Project Maintenance and Documentation switch places every few releases.
* [#180] Provide an admin overview for notificatie responses | ||
* [#207] Add experimental PUT and PATCH for Kanaal | ||
|
||
**Project maintenance** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is missing form the change log: #212 (not too important)
**Bugfixes and QOL** | ||
|
||
* [#66] updated commonground-api-common to 2.1.0 (TBD) | ||
* [maykinmedia/open-api-framework#66] Update zgw consumers to 0.36.0 | ||
* [maykinmedia/open-api-framework#46] Upgrade open-api-framework to 0.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (OAF 0.9.1) is a new feature and adds ability to manage user sessions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also (re)added CELERY_LOGLEVEL
enviroment which fixed celery log level not working.
Which is a separate bug fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changes LOG_STDOUT to be true by default. (would be a QOl change)
Should have a warning:
.. warning::
``LOG_STDOUT`` configuration variable now defaults to ``True`` instead of ``False``
* [maykinmedia/open-api-framework#66] Update zgw consumers to 0.36.0 | ||
* [maykinmedia/open-api-framework#46] Upgrade open-api-framework to 0.9.1 | ||
* [#199] Upgrade mozilla-django-oidc-db to 0.21.1 | ||
* [#203] Upgrade notifications-api-common to 0.4.0 | ||
* [#204] Upgrade django-setup-configuration to 0.5.0 | ||
* [#200] Upgrade commonground-api-common to 2.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these would be project maintenance, unless they provide a specific features which should be mentioned.
Create release 1.8.0