[#21] display version in admin #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
reviewed
Jun 7, 2024
Comment on lines
43
to
52
| {% block footer %} | ||
| <div id="footer"> | ||
| {% url 'admin:login' as admin_login_url %} | ||
| {% if request.path != admin_login_url %} | ||
| <div class="version" title="Git SHA: {{ settings.GIT_SHA|default:'' }}"> | ||
| {% blocktrans with version=settings.RELEASE %}version {{ version }}{% endblocktrans %} | ||
| </div> | ||
| {% endif %} | ||
| </div> | ||
| {% endblock %} |
There was a problem hiding this comment.
Maybe this is something that should be part of open-api-framework, @annashamray thoughts?
There was a problem hiding this comment.
Similar question with the ENVIRONMENT_SHOWN_IN_ADMIN in the template. maykinmedia/referentielijsten#14 (comment)
There was a problem hiding this comment.
@stevenbal I agree, it looks like it belongs to open-api-framework
This was referenced Jun 7, 2024
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
0a3ebd3 to
94083be
Compare
SonnyBA
force-pushed
the
feature/#21-show-version-admin
branch
from
3302c39 to
80eec3c
Compare
stevenbal
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes maykinmedia/open-api-framework#21