Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tlv info support #392

Merged
merged 7 commits into from
Nov 6, 2024
Merged

Custom tlv info support #392

merged 7 commits into from
Nov 6, 2024

Conversation

Vibaswan
Copy link
Contributor

@Vibaswan Vibaswan commented Nov 4, 2024

Fixes #393

Change of oui-subtype field in get_states LLDP Custom TLV node from string to unit32

Adding support for information field in LLDP custom TLV learned info

Redocly Link

basically everything remains same just an addition of property information in path States.Response/LldpNeighbhors.State/LldpCustomTLV.State

snappi-snippet

# request
request = api.states_request()
request.lldp_neighbors.lldp_names = []
response = api.get_states(request)

# response
neighbors = response.lldp_neighbors
neighbor = neighbors [0]
neighbor.custom_type  # type: unit32 example_value- 0
neighbor.oui  # type: hex_string example_value- "0:80:C2"
neighbor.oui_subtype  # type: uint32 example_value- 1 
# newly added
neighbor.information # type hex_string example_value- "0030ae"

Copy link
Contributor

@apratimmukherjee apratimmukherjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes is desc.
Add Issue and link.
snappi python snippet to access new field.
Note gnmi PR TBD later for completion.

result/lldpneighbors.yaml Outdated Show resolved Hide resolved
result/lldpneighbors.yaml Outdated Show resolved Hide resolved
@apratimmukherjee apratimmukherjee merged commit 80b76bc into master Nov 6, 2024
@apratimmukherjee apratimmukherjee deleted the custom_tlv_info_support branch November 6, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Information field in LLDP custom TLV for get_states operation in OTG model
3 participants