-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Otg refactor #1
base: main
Are you sure you want to change the base?
Otg refactor #1
Conversation
…code for ixia and replaced explicit ixiatg type declarations with ixatg package
if status.State == state { | ||
log.Infof("Attained ixia CRD state %s", state) | ||
return status, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a 20 / 50 ms sleep; break busy spin.
for i := range crd.Status.Interfaces { | ||
for j := range pod.Items { | ||
if pod.Items[j].Name == crd.Status.Interfaces[i].PodName { | ||
pods[i+1] = &pod.Items[j] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break from loop
|
||
for i := range pod.Items { | ||
if pod.Items[i].Name == crd.Status.ApiEndPoint.PodName { | ||
pods[0] = &pod.Items[i] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again break here
for i := range crd.Status.ApiEndPoint.ServiceName { | ||
for j := range svc.Items { | ||
if svc.Items[j].Name == crd.Status.ApiEndPoint.ServiceName[i] { | ||
svcs[i] = &svc.Items[j] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break here
topo/node/ixia/ixia.go
Outdated
state = node.NODE_PENDING | ||
} | ||
|
||
return state, nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ensure we also return reason for failed cases
…ect failure reason from ixia CRD
No description provided.