Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otg refactor #1

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Otg refactor #1

wants to merge 12 commits into from

Conversation

ashutshkumr
Copy link

No description provided.

if status.State == state {
log.Infof("Attained ixia CRD state %s", state)
return status, nil
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a 20 / 50 ms sleep; break busy spin.

for i := range crd.Status.Interfaces {
for j := range pod.Items {
if pod.Items[j].Name == crd.Status.Interfaces[i].PodName {
pods[i+1] = &pod.Items[j]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break from loop


for i := range pod.Items {
if pod.Items[i].Name == crd.Status.ApiEndPoint.PodName {
pods[0] = &pod.Items[i]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again break here

for i := range crd.Status.ApiEndPoint.ServiceName {
for j := range svc.Items {
if svc.Items[j].Name == crd.Status.ApiEndPoint.ServiceName[i] {
svcs[i] = &svc.Items[j]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break here

state = node.NODE_PENDING
}

return state, nil
Copy link

@anjan-keysight anjan-keysight Mar 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure we also return reason for failed cases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants