-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fr] Move new observability primer page #5927
base: main
Are you sure you want to change the base?
[fr] Move new observability primer page #5927
Conversation
* moved observability-primer.md under fr/docs/concepts
It looks like there are now hash issues in links (see the failing GH Action). |
* Updated hastag in what-is-opentelemetry.md
New attempt to fix the link issue
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12766122241 |
IMPORTANT: (RE-)RUN
|
* Testing a fix
* Attempt to fix the link issue from _index.md
* Fixed the link issue (adopted the same url format as the Spanish and Portuguese versions)
* Fixed remaining bug
@@ -57,7 +57,7 @@ performance et le comportement de vos logiciels. | |||
|
|||
{{% blocks/section color="dark" type="row" %}} | |||
|
|||
{{% blocks/feature icon="fas fa-chart-line" title="Traces, Métriques, Logs" url="docs/concepts/observability-primer/" %}} | |||
{{% blocks/feature icon="fas fa-chart-line" title="Traces, Métriques, Logs" %}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? It is forcing a difference between the fr
and en
pages (which shouldn't be necessary) and invalidating the default_lang_commit
value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chalin : I was struggling to solve the link issue in the _index.md file. I checked how other languages handled this and noticed that both the Spanish and Portuguese versions removed this URL.
Apparently this modification did not solve my issue either :( . Any idea how I could solve the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, please revert this change, and we'll address any link-checking failures separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as unresolved since the change hasn't been reverted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to my other comment, the changes made here need to be undone.
The "hash does not exist" link-check failures of this PR are because |
In passing, I'd like to suggest that you add "Fixes #XXXX" to the opening comment of a PR rather than the title. By doing so you allow GitHub to automatically link the PR to the issue. This make is easier for all to navigate to the issue, and allows GitHub to know that the issue can be closed when the PR is merged. (I've edited the comment to this effect, hopefully, that's ok with you.) |
This reverts commit 32e5fea.
…etry#5913 * Moves observability-primer.md under fr/docs/concepts
docs
#5913