Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fr] Move new observability primer page #5927

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

iguitton
Copy link
Contributor

@iguitton iguitton commented Jan 14, 2025

* moved observability-primer.md under fr/docs/concepts
@iguitton iguitton requested a review from a team as a code owner January 14, 2025 09:30
@opentelemetrybot opentelemetrybot requested review from a team January 14, 2025 09:30
@dmathieu
Copy link
Member

It looks like there are now hash issues in links (see the failing GH Action).

* Updated hastag in what-is-opentelemetry.md
@iguitton
Copy link
Contributor Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12766122241

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@@ -57,7 +57,7 @@ performance et le comportement de vos logiciels.

{{% blocks/section color="dark" type="row" %}}

{{% blocks/feature icon="fas fa-chart-line" title="Traces, Métriques, Logs" url="docs/concepts/observability-primer/" %}}
{{% blocks/feature icon="fas fa-chart-line" title="Traces, Métriques, Logs" %}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? It is forcing a difference between the fr and en pages (which shouldn't be necessary) and invalidating the default_lang_commit value.

Copy link
Contributor Author

@iguitton iguitton Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalin : I was struggling to solve the link issue in the _index.md file. I checked how other languages handled this and noticed that both the Spanish and Portuguese versions removed this URL.

Apparently this modification did not solve my issue either :( . Any idea how I could solve the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be clear, please revert this change, and we'll address any link-checking failures separately.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as unresolved since the change hasn't been reverted.

@chalin chalin changed the title Issue #5913 Move new observability primer page [fr] Move new observability primer page Jan 14, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to my other comment, the changes made here need to be undone.

@chalin
Copy link
Contributor

chalin commented Jan 14, 2025

The "hash does not exist" link-check failures of this PR are because content/fr/docs/what-is-opentelemetry.md doesn't have heading IDs, as recommended in Localization > Heading anchors. The proper fix is here is to add the heading IDs in content/fr/docs/what-is-opentelemetry.md.

@chalin
Copy link
Contributor

chalin commented Jan 14, 2025

In passing, I'd like to suggest that you add "Fixes #XXXX" to the opening comment of a PR rather than the title. By doing so you allow GitHub to automatically link the PR to the issue. This make is easier for all to navigate to the issue, and allows GitHub to know that the issue can be closed when the PR is merged. (I've edited the comment to this effect, hopefully, that's ok with you.)

@opentelemetrybot opentelemetrybot requested review from a team January 15, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[fr] Move new observability-primer page under docs
4 participants