Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data type in yaml #5901

Merged
merged 2 commits into from
Jan 11, 2025
Merged

Fix data type in yaml #5901

merged 2 commits into from
Jan 11, 2025

Conversation

tapiau
Copy link
Contributor

@tapiau tapiau commented Jan 8, 2025

fix: transform should be array item, not map

@tapiau
Fix data type in yaml
9fb117f 
fix: action should be array item, not map
@tapiau tapiau requested a review from a team as a code owner January 8, 2025 10:16
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jan 8, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tapiau / name: Zbigniew 'zibi' Jarosik (9fb117f)
  • ✅ login: cartermp / name: Phillip Carter (d48a85e)

@opentelemetrybot opentelemetrybot requested review from a team and atoulme and removed request for a team January 8, 2025 10:16
@cartermp
Copy link
Contributor

cartermp commented Jan 9, 2025

@tapiau could you sign the CLA? Then we can review. Thanks!

@svrnm svrnm added the CLA: no label Jan 10, 2025
@tapiau
Copy link
Contributor Author

tapiau commented Jan 10, 2025

gif: i don't want to live on this planet anymore

This is hideous. I understand to sign bunch of papers donating kidney, but dash and five spaces?!

@cartermp cartermp removed the CLA: no label Jan 11, 2025
cartermp
cartermp approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, unfortunately this is the policy with CNCF assets. It's a legal protection thing.

@opentelemetrybot opentelemetrybot requested a review from a team January 11, 2025 16:36
@cartermp cartermp added this pull request to the merge queue Jan 11, 2025
Merged via the queue into open-telemetry:main with commit fe4b222 Jan 11, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartermp cartermp cartermp approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
sig:collector
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tapiau @cartermp @svrnm