Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document required quoting of booleans in php.ini #5849

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Dec 24, 2024

Update PHP configuration documentation to mention that boolean values need to be protected by double-quotes
if provided via php.ini.

Closes: open-telemetry/opentelemetry-php#1442

@brettmc brettmc requested a review from a team as a code owner December 24, 2024 02:48
@opentelemetrybot opentelemetrybot requested a review from a team December 24, 2024 02:49
@brettmc brettmc changed the title Php ini boolean Document required quoting of booleans in php.ini Dec 24, 2024
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp added this pull request to the merge queue Dec 25, 2024
Merged via the queue into open-telemetry:main with commit 8f36688 Dec 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Reading boolean configuration values via php.ini is impossible due to architecture
2 participants