Change internal logs config example to use OTLP/HTTP #5831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
a team and
songy23
and removed request for
a team
songy23
approved these changes
Dec 20, 2024
svrnm
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a somewhat outdated dependency, the Collector does not yet have support for exporting internal logs through OTLP/gRPC, only through OTLP/HTTP. Because of this, the example config added to the "Internal telemetry" docs page in PR #5702 does not actually work, and will result in an "unsupported protocol" error. There is work underway to fix this, but according to @codeboten, it is blocked by other work, and may take some time to be merged.
For this reason, in the meantime, this PR updates the example config to use OTLP/HTTP instead of OTLP/gRPC, to avoid confusing users who try to use the example as-is.