Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new blog by OTel CI/CD SIG - Repost from cncf.io/blogs #5718

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

horovits
Copy link
Contributor

@horovits horovits commented Dec 3, 2024

This is a post by SIG CI/CD Observability, which was posted on cncf.io towards KubeCon NA '24.
Submitting in accordance with the approved issue 5546: #5546

Note: due to lack of support in the OTel blog in embedding social media (thanks @svrnm for the clarification), those embeds from the original CNCF blog have been omitted.
If there's a way to support those, please let me know and I'd be happy to amend.

@horovits horovits requested a review from a team as a code owner December 3, 2024 09:47
Copy link

linux-foundation-easycla bot commented Dec 3, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the blog label Dec 3, 2024
@opentelemetrybot opentelemetrybot requested a review from a team December 3, 2024 09:47
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A first quick review, PTAL

content/en/blog/2024/otel-cicd-sig/index.md Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestions and copy edits. Thanks!

content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
content/en/blog/2024/otel-cicd-sig/index.md Outdated Show resolved Hide resolved
Co-authored-by: Severin Neumann <[email protected]>
Co-authored-by: Tiffany Hrabusa <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team December 4, 2024 10:11
@svrnm
Copy link
Member

svrnm commented Dec 4, 2024

@horovits since you provided that feedback across multiple comments by @tiffany76, I'll address it here:

this is a syndicated article from the CNCF.io blog, I'd rather not change wording unless meaningful.

I disagree with that. We (SIG Comms) allow the re-publication of blog posts from other sources, acknowledging that there are reasons making this necessary, but we will not bend on our standards of quality, this includes that we provide rich copy editing feedback to blog authors. We are very lucky that we have experienced technical writers like @tiffany76 in our SIG who spend time and effort to ensure that. Please reciprocate with spending your time and effort to either accept the feedback or engage in a meaningful discussion.

horovits and others added 2 commits December 5, 2024 15:27
per @tiffany76 review:

Although trace and event are defined terms in OpenTelemetry, they are common nouns and should not be capitalized. To illustrate: the OpenTelemetry Collector is capitalized because it is a proper noun referring to a specific collector. If you refer to other collectors, the term is not capitalized.

Co-authored-by: Tiffany Hrabusa <[email protected]>
delete extra blank lines
@svrnm
Copy link
Member

svrnm commented Dec 18, 2024

@horovits please take a look at the feedback provided. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants