-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new blog by OTel CI/CD SIG - Repost from cncf.io/blogs #5718
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A first quick review, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style suggestions and copy edits. Thanks!
Co-authored-by: Severin Neumann <[email protected]> Co-authored-by: Tiffany Hrabusa <[email protected]>
accept suggestion Co-authored-by: Tiffany Hrabusa <[email protected]>
@horovits since you provided that feedback across multiple comments by @tiffany76, I'll address it here:
I disagree with that. We (SIG Comms) allow the re-publication of blog posts from other sources, acknowledging that there are reasons making this necessary, but we will not bend on our standards of quality, this includes that we provide rich copy editing feedback to blog authors. We are very lucky that we have experienced technical writers like @tiffany76 in our SIG who spend time and effort to ensure that. Please reciprocate with spending your time and effort to either accept the feedback or engage in a meaningful discussion. |
per @tiffany76 review: Although trace and event are defined terms in OpenTelemetry, they are common nouns and should not be capitalized. To illustrate: the OpenTelemetry Collector is capitalized because it is a proper noun referring to a specific collector. If you refer to other collectors, the term is not capitalized. Co-authored-by: Tiffany Hrabusa <[email protected]>
delete extra blank lines
@horovits please take a look at the feedback provided. Thanks |
per @svrnm editorial review open-telemetry#5718 (comment)
per @tiffany76 editorial Co-authored-by: Tiffany Hrabusa <[email protected]>
This is a post by SIG CI/CD Observability, which was posted on cncf.io towards KubeCon NA '24.
Submitting in accordance with the approved issue 5546: #5546
Note: due to lack of support in the OTel blog in embedding social media (thanks @svrnm for the clarification), those embeds from the original CNCF blog have been omitted.
If there's a way to support those, please let me know and I'd be happy to amend.