-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add info about React Native app #5704
base: main
Are you sure you want to change the base?
[Demo] Add info about React Native app #5704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good overall, a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a general comment, I don't think that the app should be documented as a part of the demo/services
. Even the entry in the index page reads, "React Native mobile application that provides a UI on top of the shopping services."
How does it relate to the Collector?
Maybe we need a new Demo top-level entry?
I actually disagree @chalin.
As well as the other services, the reactive-native-app is instrumented with OTel and sends traces to the Collector. |
I agree with @julianocosta89 here. The |
Marking this as Ready to Review now that the associated PR in the demo repo got merged: open-telemetry/opentelemetry-demo#1781 (comment) Will updated and take a look at the check failures |
I'm not quite sure how to address the failure on the "Build and Check Links" check, it appears to fail on running |
/fix:htmltest-config |
You triggered fix:htmltest-config action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422284976 |
IMPORTANT: (RE-)RUN
|
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422305906 |
fix:all failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/12422305906. |
I think the issue is fixed, but the CI checks need to be triggered again. Maybe try a rebase? |
@jpmunz @tiffany76 let's ignore the build issues for now, we can fix them once the PR is approved by @open-telemetry/demo-approvers and @open-telemetry/docs-approvers and before we merge it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 📱📱📱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a few small copy edits.
## Instrumentation | ||
|
||
The application uses the OpenTelemetry packages to instrument the application at | ||
the JS layer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the JS layer | |
the JS layer. |
The JS OTel packages are supported for node and web environments. While they | ||
work for React Native as well they are not currently explicitly supported for | ||
that environment and may break compatibility with minor version updates or | ||
require workarounds. Building more support for React Native is an area of active | ||
development. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JS OTel packages are supported for node and web environments. While they | |
work for React Native as well they are not currently explicitly supported for | |
that environment and may break compatibility with minor version updates or | |
require workarounds. Building more support for React Native is an area of active | |
development. | |
The JS OTel packages are supported for node and web environments. While they | |
work for React Native as well, they are not explicitly supported for | |
that environment, where they might break compatibility with minor version updates or | |
require workarounds. Building JS Otel package support for React Native is an area of active | |
development. |
This updates the demo documentation to include the React Native example app that was added here: open-telemetry/opentelemetry-demo#1781
Preview: https://deploy-preview-5704--opentelemetry.netlify.app/docs/demo/services/react-native-app/