Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"feat: [es] Create observability-primer.md " #5302

Merged

Conversation

mlunadia
Copy link
Contributor

@mlunadia mlunadia commented Oct 3, 2024

feat: [es] Create observability-primer.md
Related to #5206

@mlunadia mlunadia requested a review from a team as a code owner October 3, 2024 22:10
@opentelemetrybot opentelemetrybot requested review from a team and krol3 and removed request for a team October 3, 2024 22:10
@opentelemetrybot opentelemetrybot requested a review from a team October 3, 2024 22:18
@mlunadia
Copy link
Contributor Author

mlunadia commented Oct 3, 2024

@krol3 I see spelling checks are failing for Spanish words, perhaps we need to update the tests to include Spanish or how can we add words to the vocabulary?

Copy link
Member

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente trabajo, @mlunadia, tan solo una sugerencias de estilo (que estoy consolidando en un documento).

Sobre los errores de spelling, el diccionario no es del todo completo. Sugiero añadir las excepciones en el frontmatter usandp cSpell:ignore: o bien a https://github.com/open-telemetry/opentelemetry.io/blob/main/.cspell/es-palabras.txt

content/es/docs/concepts/observability-primer.md Outdated Show resolved Hide resolved
content/es/docs/concepts/observability-primer.md Outdated Show resolved Hide resolved
content/es/docs/concepts/observability-primer.md Outdated Show resolved Hide resolved
content/es/docs/concepts/observability-primer.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team October 4, 2024 11:30
@mlunadia
Copy link
Contributor Author

mlunadia commented Oct 4, 2024

Gracias @theletterf por las sugerencias!

@theletterf
Copy link
Member

@mlunadia The spelling errors are still there, please check them out.

@mlunadia
Copy link
Contributor Author

mlunadia commented Oct 4, 2024

@theletterf ah, got it. added them to the txt file, pending PR approval.

@theletterf
Copy link
Member

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11194657075

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf
Copy link
Member

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/11194669606

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@theletterf theletterf added this pull request to the merge queue Oct 5, 2024
Merged via the queue into open-telemetry:main with commit d38229d Oct 5, 2024
5 checks passed
taylorhelene pushed a commit to taylorhelene/opentelemetry.io that referenced this pull request Oct 7, 2024
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants