Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to PrometheusHttpServer in prometheus-setup.md #5038

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

theletterf
Copy link
Member

Fixes #5018

@theletterf theletterf requested a review from a team August 14, 2024 07:44
@theletterf theletterf self-assigned this Aug 14, 2024
@theletterf theletterf changed the title Update prometheus-setup.md Update link to PrometheusHttpServer in prometheus-setup.md Aug 14, 2024
@theletterf
Copy link
Member Author

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10383696079

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait...

[`PrometheusHttpServer`](https://javadoc.io/doc/io.opentelemetry/opentelemetry-exporter-prometheus/latest/io/opentelemetry/exporter/prometheus/PrometheusHttpServer.html),
[`PrometheusHttpServer`](https://open-telemetry.github.io/opentelemetry-js/classes/_opentelemetry_exporter_prometheus.PrometheusExporter.html),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a shortcode, so it is applied all languages using that shortcode, meaning we need to inject the correct URL as a parameter to the short code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That also crossed my mind... Hmmm. Should we remove the link entirely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not even the name is consistent across languages, so yes, maybe "Prometheus Exporter" without link and without the code-style

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edited in 8e4ec8c, have a look!

@theletterf theletterf requested a review from svrnm August 14, 2024 08:30
@theletterf
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10384236663

@svrnm svrnm added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 72a9e28 Aug 14, 2024
7 checks passed
@svrnm svrnm deleted the theletterf-patch-1 branch August 14, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Wrong PrometheusHttpServer link in js exporters documentation
3 participants