Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Add /pt/docs/concepts/signals/trace.md #5019

Merged
merged 10 commits into from
Aug 23, 2024

Conversation

EzzioMoreira
Copy link
Contributor

Add a localization trace signal.

Issue: #4922

@EzzioMoreira EzzioMoreira changed the title [pt] Add /pt/docs/concepts/signals [pt] Add /pt/docs/concepts/signals/trace.md Aug 12, 2024
Copy link
Member

@edsoncelio edsoncelio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deixei algumas sugestões!

content/pt/docs/concepts/signals/traces.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/signals/traces.md Show resolved Hide resolved
content/pt/docs/concepts/signals/traces.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/signals/traces.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/signals/traces.md Outdated Show resolved Hide resolved
content/pt/docs/concepts/signals/traces.md Outdated Show resolved Hide resolved
@edsoncelio edsoncelio mentioned this pull request Aug 12, 2024
26 tasks
@EzzioMoreira
Copy link
Contributor Author

@edsoncelio obrigado pela revisão ❤️.
en: Thanks for your review.

@EzzioMoreira EzzioMoreira marked this pull request as ready for review August 16, 2024 23:45
@EzzioMoreira EzzioMoreira requested a review from a team August 16, 2024 23:45
@theletterf theletterf requested a review from edsoncelio August 22, 2024 08:05
@edsoncelio
Copy link
Member

LGTM!
PTAL @emdneto

@chalin
Copy link
Contributor

chalin commented Aug 22, 2024

Waiting on a @open-telemetry/docs-pt-approvers

@opentelemetrybot opentelemetrybot requested review from a team August 22, 2024 23:15
Para mais informações sobre o tipo de Trecho, consulte
[SpanKind](/docs/specs/otel/trace/api/#spankind).

#### Client
Copy link
Member

@emdneto emdneto Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fiquei na dúvida sobre esses termos aqui não traduzidos e mais abaixo usamos o termo em pt, mas LGTM

@chalin
Copy link
Contributor

chalin commented Aug 23, 2024

Given @emdneto formal approval and LGTM (despite the nit), I'm scheduling this to be merged.

@chalin chalin added this pull request to the merge queue Aug 23, 2024
Merged via the queue into open-telemetry:main with commit a7b2925 Aug 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants