Update propagation page for Node.js #4722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svrnm <[email protected]>
theletterf
approved these changes
Jun 20, 2024
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
svrnm
commented
Jun 20, 2024
trentm
reviewed
Jun 20, 2024
Co-authored-by: Trent Mick <[email protected]>
|
/fix:all |
|
@open-telemetry/javascript-approvers please take a look! |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9648516390 |
chalin
approved these changes
Jun 25, 2024
| propagate trace context across services for you. Only in rare cases you will | ||
| need to propagate context manually. | ||
|
|
||
| {{ if $lang -}} |
There was a problem hiding this comment.
Why have conditional content based on $lang? The prose in the "then" clause below seems suitable in all cases.
If we don't need the "lang" parameter to the shortcode, I'd suggest that we drop it for now, and reintroduce it later if/when needed.
There was a problem hiding this comment.
The page this is referencing is /docs/concepts/context-propagation, so that would be self-referencing
Co-authored-by: Patrice Chalin <[email protected]>
Co-authored-by: Trent Mick <[email protected]>
|
/fix:all |
|
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/9790310929 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3688, this is a detailed updated on context propagation, that when applied can be replicated across languages.
Preview: https://deploy-preview-4722--opentelemetry.netlify.app/docs/languages/js/propagation/