Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go code excerpts #4712

Closed
wants to merge 2 commits into from
Closed

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Jun 18, 2024

Replaces #4678

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just a run of the code-excerpt tooling over the docs?
What's left to do (why the draft status)?

@svrnm
Copy link
Member Author

svrnm commented Jul 25, 2024

Is this just a run of the code-excerpt tooling over the docs? What's left to do (why the draft status)?

If I remember correctly a file was extracted (lines 411 to 423) and this needs to be added to the text. Tbh I forgot about this issue/didn't get to it

@svrnm svrnm requested a review from a team July 25, 2024 09:56
@pellared
Copy link
Member

@svrnm
Copy link
Member Author

svrnm commented Jul 25, 2024

FYI the changes look wrong. See open-telemetry/opentelemetry-go@main/example/dice/rolldice.go

the changes are based on the release we have pinned the submodule to (v1.27.0), we might need a more robust workflow here, especially when files are forked out

@pellared
Copy link
Member

the changes are based on the release we have pinned the submodule to (v1.27.0),

And we already have v1.28.0:

@svrnm
Copy link
Member Author

svrnm commented Jul 25, 2024

the changes are based on the release we have pinned the submodule to (v1.27.0),

And we already have v1.28.0:

* [open-telemetry/opentelemetry-go@`v1.28.0`/example/dice/rolldice.go](https://github.com/open-telemetry/opentelemetry-go/blob/v1.28.0/example/dice/rolldice.go?rgh-link-date=2024-07-25T10%3A36%3A57Z)

That's what I mean with we need a robust workflow... we might want to consider creating automation for bumping the submodules whenever an update occurs, however if these files get changed but no new version is released, we still need to go down the manual path.

@svrnm
Copy link
Member Author

svrnm commented Sep 9, 2024

I need to take a fresh look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants