-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go code excerpts #4712
Update go code excerpts #4712
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just a run of the code-excerpt tooling over the docs?
What's left to do (why the draft status)?
If I remember correctly a file was extracted (lines 411 to 423) and this needs to be added to the text. Tbh I forgot about this issue/didn't get to it |
FYI the changes look wrong. See https://github.com/open-telemetry/opentelemetry-go/blob/main/example/dice/rolldice.go |
the changes are based on the release we have pinned the submodule to (v1.27.0), we might need a more robust workflow here, especially when files are forked out |
And we already have v1.28.0: |
That's what I mean with we need a robust workflow... we might want to consider creating automation for bumping the submodules whenever an update occurs, however if these files get changed but no new version is released, we still need to go down the manual path. |
I need to take a fresh look at this |
Replaces #4678