Add example for sync gauge in Go #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
Jun 6, 2024
|
|
||
| Gauges are used to measure non-additive values when changes occur. | ||
|
|
||
| For example, here's how you report the speed of a CPU fan: |
There was a problem hiding this comment.
Suggested change
| For example, here's how you report the speed of a CPU fan: | |
| For example, here's how you might report the current speed of a CPU fan: |
| panic(err) | ||
| } | ||
| http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { | ||
| speedGauge.Record(r.Context(), 1500) |
There was a problem hiding this comment.
Suggested change
| speedGauge.Record(r.Context(), 1500) | |
| // hard-code 1500 RPM for demonstrative purposes | |
| speedGauge.Record(r.Context(), 1500) |
There was a problem hiding this comment.
Thanks for the suggestion. Applied and pushed.
- Changed gauge explanation - Added comment
dmathieu
approved these changes
Jun 6, 2024
cartermp
removed
the
sig-approval-missing
theletterf
reviewed
Jun 7, 2024
| @@ -534,6 +534,35 @@ func removeItem() { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Using Gauges | |||
There was a problem hiding this comment.
Suggested change
| ### Using Gauges | |
| ### Using gauges |
We use sentence case in titles.
There was a problem hiding this comment.
Thank you for the feedback. I noticed that other titles like 'Using Histograms' also start with capital letters. Could you give me more detail on which part i should fix?
ymotongpoo
pushed a commit
to ymotongpoo/opentelemetry.io
that referenced
this pull request
Jun 8, 2024
Co-authored-by: Phillip Carter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added example for sync gauge in Go.
This is part of following issue:
open-telemetry/opentelemetry-go#5414