-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spring Boot starter: Alias fixes and partial copyedits #4563
Spring Boot starter: Alias fixes and partial copyedits #4563
Conversation
2550adf
to
ed7485d
Compare
General question to all: I see that the term "OpenTelemetry Starter" is used to refer to the Spring Boot Starter, that doesn't seem right to me. Do you agree? Instead the term used should just be "Spring Boot Starter" (or just "Starter" if the context is clear enough). WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
content/en/docs/zero-code/java/spring-boot-starter/additional-instrumentations.md
Outdated
Show resolved
Hide resolved
I think "Spring Boot Starter" is the better term. |
Spring Boot provides the possibilty to create starters: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#using.build-systems.starters The full name would be "OpenTelemetry Spring Boot starter". "OpenTelemetry starter" is shorter and could be understood as a "Spring Boot starter" in the context of Spring Boot applications. |
Thanks for the clarification @jeanbisutti. I propose that we address this separately, see: |
4529b42
to
6a96e28
Compare
Thanks all! Merging since we have all of the necessary approvals, and the build checks are passing |
Preview: https://deploy-preview-4563--opentelemetry.netlify.app/docs/zero-code/java/spring-boot-starter/
Redirect tests:
This confirms the fix for the link failure reported in https://github.com/open-telemetry/opentelemetry-java-examples/actions/runs/9242715195/job/25527124585?pr=416. /cc @zeitlinger
/cc @jeanbisutti