Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring Boot starter: Alias fixes and partial copyedits #4563

Conversation

@chalin chalin requested review from a team May 30, 2024 22:49
@github-actions github-actions bot added the blog label May 30, 2024
@chalin chalin force-pushed the chalin-im-spring-boot-starter-fixes-2024-05-30 branch 3 times, most recently from 2550adf to ed7485d Compare May 30, 2024 23:07
@chalin chalin mentioned this pull request May 30, 2024
@chalin
Copy link
Contributor Author

chalin commented May 31, 2024

General question to all: I see that the term "OpenTelemetry Starter" is used to refer to the Spring Boot Starter, that doesn't seem right to me. Do you agree? Instead the term used should just be "Spring Boot Starter" (or just "Starter" if the context is clear enough). WDYT?

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@cartermp
Copy link
Contributor

I think "Spring Boot Starter" is the better term.

@jeanbisutti
Copy link
Member

Spring Boot provides the possibilty to create starters: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#using.build-systems.starters

The full name would be "OpenTelemetry Spring Boot starter". "OpenTelemetry starter" is shorter and could be understood as a "Spring Boot starter" in the context of Spring Boot applications.

@chalin
Copy link
Contributor Author

chalin commented May 31, 2024

Spring Boot provides the possibilty to create starters: https://docs.spring.io/spring-boot/docs/current/reference/htmlsingle/#using.build-systems.starters

The full name would be "OpenTelemetry Spring Boot starter". "OpenTelemetry starter" is shorter and could be understood as a "Spring Boot starter" in the context of Spring Boot applications.

Thanks for the clarification @jeanbisutti. I propose that we address this separately, see:

@chalin chalin force-pushed the chalin-im-spring-boot-starter-fixes-2024-05-30 branch from 4529b42 to 6a96e28 Compare May 31, 2024 06:57
@chalin
Copy link
Contributor Author

chalin commented May 31, 2024

Thanks all! Merging since we have all of the necessary approvals, and the build checks are passing

@chalin chalin changed the title Spring boot starter: Alias fixes and partial copyedits Spring Boot starter: Alias fixes and partial copyedits May 31, 2024
@chalin chalin merged commit 8c61967 into open-telemetry:main May 31, 2024
15 checks passed
@chalin chalin deleted the chalin-im-spring-boot-starter-fixes-2024-05-30 branch May 31, 2024 07:03
@chalin chalin removed the blog label May 31, 2024
@chalin chalin added this to the 24Q2 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants