Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrumentation.md #4516

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

aaaugustine29
Copy link
Contributor

Both the W3CBaggagePropagator and the TextMapPropagator were not included in the list of imports. This introduces compilation errors in the current configuration due to use of these packages in line 59: ".setPropagators(ContextPropagators.create(TextMapPropagator.composite(W3CTraceContextPropagator.getInstance(), W3CBaggagePropagator.getInstance())))"

Both the W3CBaggagePropagator and the TextMapPropagator were not included in the list of imports. This introduces compilation errors in the current configuration due to use of these packages in ".setPropagators(ContextPropagators.create(TextMapPropagator.composite(W3CTraceContextPropagator.getInstance(), W3CBaggagePropagator.getInstance())))"
@aaaugustine29 aaaugustine29 requested review from a team May 21, 2024 13:10
Copy link

linux-foundation-easycla bot commented May 21, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cartermp / name: Phillip Carter (86181ec)
  • ✅ login: aaaugustine29 (982eaec)
  • ✅ login: breedx-splk / name: jason plumb (02aa69b)

@svrnm svrnm added the sig-approval-missing Co-owning SIG didn't provide an approval label May 22, 2024
@cartermp cartermp merged commit 3a1705f into open-telemetry:main May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig:java sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants