-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create blog post about Prometheus and OpenTelemetry #4119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits in a first pass. I really like the topic and the content! My only concern is that, from the title, I expected a more conceptual post, but then the post delves into a rather detailed tutorial. Could there be a way of better setting expectations from the title and intro?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a lot of text :) Please see comments.
Also requesting a review from @open-telemetry/operator-ta-maintainers |
Incorporated suggestion from [this review](#4119 (review)).
@theletterf I incorporated your comment about setting clearer expectations in the intro. Is this more effective?
|
Specifically address this [review comment](#4119 (comment)).
This specifically addresses [this review comment](#4119 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thanks!
content/en/blog/2024/prom-and-otel/target-allocator-sharding.png
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for writing this! Looking forward to your Kubecon talk!
I left a few notes that I think better represent the Prometheus capabilities.
Addresses [this review comment](#4119 (comment)) and [this one](#4119 (comment)).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hype!! Thanks for writing this up!
Addresses this [review comment](#4119 (comment)).
Addresses [this review comment](#4119 (comment)).
Also, this just got published: https://prometheus.io/blog/2024/03/14/commitment-to-opentelemetry/ Maybe at the end we can add reference saying something along the line of "Prometheus is also making it easier to integrate natively with OpenTelemetry and here are their plans."? |
@gouthamve Gotchu! I added this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reese-lee added the mermaid diagrams. The closing back-ticks for the mermaid diagrams weren't rendering properly. You may have to manually add them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add link to OTel Operator
@chalin we can point to this PR for the "rebase vs not-rebase" discussion, I am convinced now ;-) |
@open-telemetry/wg-prometheus PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor things :) otherwise this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great post!
Co-authored-by: Jacob Aronoff <[email protected]>
@reese-lee please take a look at the outstanding review comments |
@reese-lee @avillela any updates? |
Co-authored-by: Adriana Villela <[email protected]>
@svrnm Thank you for your patience! I believe we are good to go on this (finally). I'm not sure what to do about this failing check: "Component owners / Assign component owners (pull_request_target)"? |
let me fix the failing CI checks and then I can merge it:-) |
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
) Signed-off-by: svrnm <[email protected]> Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]> Co-authored-by: Arve Knudsen <[email protected]> Co-authored-by: Cijo Thomas <[email protected]> Co-authored-by: Goutham Veeramachaneni <[email protected]> Co-authored-by: Jacob Aronoff <[email protected]> Co-authored-by: Adriana Villela <[email protected]> Co-authored-by: Severin Neumann <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: opentelemetrybot <[email protected]>
This is a blog post written by myself and @avillela. It is based on a talk we are delivering at KubeCon EU 2024. It is about how OpenTelemetry and Prometheus can work together, and talks about some of the different components available in OTel for your Prometheus metrics.
Preview: https://deploy-preview-4119--opentelemetry.netlify.app/blog/2024/prom-and-otel/