Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal-logs feature to opentelemetry-proto #2507

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jan 14, 2025

CI checks are failing due to internal-logs not being a feature defined for opentelemetry-proto: https://github.com/open-telemetry/opentelemetry-rust/actions/runs/12745545110/job/35519725802?pr=2494

Changes

  • Add internal-logs feature to opentelemetry-proto

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@utpilla utpilla requested a review from a team as a code owner January 14, 2025 01:43
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.9%. Comparing base (6cc327d) to head (eeb9f14).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2507   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     123           
  Lines      22887   22881    -6     
=====================================
  Hits       17838   17838           
+ Misses      5049    5043    -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 73859c3 into open-telemetry:main Jan 14, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants