Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix semconv template files #1312

Merged
merged 7 commits into from
Oct 22, 2023
Merged

Fix semconv template files #1312

merged 7 commits into from
Oct 22, 2023

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 20, 2023 •
edited
Loading

Changes

  • Fix links in semconv template file to refer to new semconv repo.
  • A nit fix in generator script to correctly update the version. Also remove the symbols from doc-comment causing failure.
  • The template generated source file got directly updated as part of Move the SDK out of opentelemetry crate, which is now the API only #1199. Moved those changes to template, and regenerated the files.
  • No upgrade to semconv repo/tool version is done here.

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb marked this pull request as ready for review October 20, 2023 17:30
@lalitb lalitb requested a review from a team October 20, 2023 17:30
@lalitb lalitb changed the title Fix semconv template file Fix semconv template files Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
opentelemetry-sdk/src/trace/mod.rs 100.0% <100.0%> (ø)

... and 19 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@TommyCpp TommyCpp merged commit aa586cb into open-telemetry:main Oct 22, 2023
12 checks passed
@lalitb lalitb mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lalitb @cijothomas @TommyCpp