-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make binary propagator take byte slice instead of vec #32
Make binary propagator take byte slice instead of vec #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=====================================
Coverage 43.3% 43.3%
=====================================
Files 11 11
Lines 1193 1193
=====================================
Hits 517 517
Misses 676 676 ☔ View full report in Codecov by Sentry. |
Is there anything more I need to do here? |
Looks good to merge. cc @open-telemetry/rust-maintainers |
Thanks @Alxandr ! If your time/passion permits, we'll be happy to get more contributions! |
Yeah - I'll probably be back with some issues eventually. Just trying to fix things on a deeper level in my project first. |
Fixes #31
Changes
Updates
deserialize_from_bytes
to take a byte slice instead of an owned vec.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes