Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make binary propagator take byte slice instead of vec #32

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

Alxandr
Copy link
Contributor

@Alxandr Alxandr commented Feb 6, 2024

Fixes #31

Changes

Updates deserialize_from_bytes to take a byte slice instead of an owned vec.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

Copy link

linux-foundation-easycla bot commented Feb 6, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@Alxandr Alxandr marked this pull request as ready for review February 6, 2024 20:20
@Alxandr Alxandr requested a review from a team February 6, 2024 20:20
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c56e309) 43.3% compared to head (ca3709b) 43.3%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #32   +/-   ##
=====================================
  Coverage   43.3%   43.3%           
=====================================
  Files         11      11           
  Lines       1193    1193           
=====================================
  Hits         517     517           
  Misses       676     676           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alxandr
Copy link
Contributor Author

Alxandr commented Feb 13, 2024

Is there anything more I need to do here?

@lalitb
Copy link
Member

lalitb commented Feb 13, 2024

Looks good to merge. cc @open-telemetry/rust-maintainers

@cijothomas cijothomas merged commit e422fbe into open-telemetry:main Feb 13, 2024
9 checks passed
@cijothomas
Copy link
Member

Thanks @Alxandr ! If your time/passion permits, we'll be happy to get more contributions!

@Alxandr
Copy link
Contributor Author

Alxandr commented Feb 14, 2024

Yeah - I'll probably be back with some issues eventually. Just trying to fix things on a deeper level in my project first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: BinaryFormat::deserialize_from_bytes should take a byte-slice, not a Vec<u8>
3 participants