Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stress test results for eventheader #140

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Dec 12, 2024

Changes

update stress test for eventheader crate. The stats don't differ whether tracepoint is enabled or disabled- as it only involves a single bit read in the kernel VFS, so haven't added separate test for it.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner December 12, 2024 08:55
@lalitb lalitb changed the title Update stress test for eventheader Update stress test results for eventheader Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.3%. Comparing base (037f914) to head (aa23e27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #140   +/-   ##
=====================================
  Coverage   54.3%   54.3%           
=====================================
  Files         41      41           
  Lines       6227    6227           
=====================================
  Hits        3384    3384           
  Misses      2843    2843           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member Author

lalitb commented Dec 12, 2024

Attaching the flamegraph with single thread, and concurrent threads ( equal to number of logical processors):

concurrent enabled check:

flamegraph_full

Single thread enabled check:
flamegraph

The relevant part in the stack trace in flamegraph is the frequent context switching in concurrent enabled graph, which is missing in single thread check, Will investigate more.

However, the PR should be good to publish with these results. The investigation can follow further.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't think we can invoke the check for each and every log, as it'll introduce contention to logging :( We can discuss some alternatives to avoid contention.

Also, we need to separately stress test if we see contention when actually exporting telemetry to user-events - it should be writing to per-cpu-buffer, so none is expected, but let us try and see if the assumptions hold true.

@cijothomas cijothomas merged commit c6974fb into open-telemetry:main Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants