fix: add attributes to get_meter wrapper #4364
Open
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On #4015 the
attributes
parameter was added for meter providers, and all interfaces were updated, but the global wrapper was not updated with the new API.Since the function doc says that "This function is a convenience wrapper for
opentelemetry.metrics.MeterProvider.get_meter
." I expect this to have the same parameters.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
First I started a aws-otel-collector docker container for testing
Then I run this minimal script.
Without this PR this fails with
Now is working as expected.
Does This PR Require a Contrib Repo Change?
Checklist: