Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Execute mypy on opentelemetry-sdk/src #4352

Closed

Conversation

prabhakarjuzgar
Copy link

@prabhakarjuzgar prabhakarjuzgar commented Dec 11, 2024

Description

Run mypy on opentelemetry-sdk/src

Fixes # 773

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • tox -e mypy

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@prabhakarjuzgar prabhakarjuzgar requested a review from a team as a code owner December 11, 2024 21:46
Copy link

linux-foundation-easycla bot commented Dec 11, 2024

CLA Missing ID

Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at this moment would be more interesting if we really start adding type hints accordingly. So, if you are still open to work on this, something like this #4053 would be very appreciate. You can also start with small fixes (i.e., single folder at max 2) which will make reviews easier. Finally, to contribute to this project you should sign CLA, please.

@prabhakarjuzgar
Copy link
Author

prabhakarjuzgar commented Dec 16, 2024

Ok, I will make changes in 1 or 2 files at a time in a PR. I am not sure if there is a way to reject this PR as I do not have permission to do so.

@xrmx xrmx closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants