sdk: decouple logs sdk setup from OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TION_ENABLED Always setup the logs sdk, keep the handler for python logging module under OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED
xrmx
commented
Dec 6, 2024
| @@ -236,6 +236,7 @@ def _init_metrics( | |||
| def _init_logging( | |||
| exporters: Dict[str, Type[LogExporter]], | |||
| resource: Resource = None, | |||
| setup_logging_handler: bool = True, | |||
There was a problem hiding this comment.
This is True to keep compatibility with old callers. I know it's a private function but still.
xrmx
commented
Dec 6, 2024
| @@ -364,7 +367,7 @@ def _initialize_components( | |||
| sampler: Optional[Sampler] = None, | |||
| resource_attributes: Optional[Attributes] = None, | |||
| id_generator: IdGenerator = None, | |||
| logging_enabled: Optional[bool] = None, | |||
| setup_logging_handler: Optional[bool] = None, | |||
There was a problem hiding this comment.
This will change behavior for custom distro implementors and so I've renamed the param name
xrmx
changed the title
aabmass
approved these changes
Dec 10, 2024
| @@ -364,7 +367,7 @@ def _initialize_components( | |||
| sampler: Optional[Sampler] = None, | |||
| resource_attributes: Optional[Attributes] = None, | |||
| id_generator: IdGenerator = None, | |||
| logging_enabled: Optional[bool] = None, | |||
| setup_logging_handler: Optional[bool] = None, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Always setup the logs sdk, keep the handler for python logging module setup under OTEL_PYTHON_LOGGING_AUTO_INSTRUMENTATION_ENABLED guard
Fixes #4329
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: