-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to type bytes for OTLP AnyValue encoding #4128
Conversation
@lzchen tagging for the review if good then can proceed to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Care to add a changelog entry and update an existing test or add a new one?
did the entry part, but couldn't find the test specifically for the encoding part, can you point me to exactly where are we testing for the encoding formats? |
Please mark this as PR if it is ready to review. |
done |
You can either add a new file here creating a test suite to just test |
Signed-off-by: wasup-yash <[email protected]>
Signed-off-by: wasup-yash <[email protected]>
what could be the reason tests are failing, is it cause the tests are not written correctly? (I am not familiar with the tests written in Python so If anyone can suggest what needs to be done here ) |
exporter/opentelemetry-exporter-otlp-proto-common/tests/test_attribute_encoder.py
Outdated
Show resolved
Hide resolved
Left a comment on how to fix your test. Also, please add a CHANGELOG entry. |
Signed-off-by: wasup-yash <[email protected]>
@wasup-yash Need to run black over your changes and add a CHANGELOG entry, I suggest to setup pre-commit as in CONTRIBUTING.md to have it done automatically at commit time. |
what does it mean though , understood the pre-commit part though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the black and the isort, check the contribution.md here
opentelemetry-python/CONTRIBUTING.md
Line 62 in 110bb73
`black` and `isort` are executed when `tox -e lint` is run. The reported errors can be tedious to fix manually. |
and about the changelog entry, you can refer to some merged PR, how they write the changelog. A randome example: #4122
Signed-off-by: wasup-yash <[email protected]>
Do I have to run |
Co-authored-by: Emídio Neto <[email protected]>
Description
Fixes #4118
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: