Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(scripts-tracecontext-integration-test.sh): fixed issue #4105 #4109

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

build(scripts-tracecontext-integration-test.sh): fixed issue #4105 #4109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4864f0c
build(scripts-tracecontext-integration-test.sh): fixed issue #4105: u…
Metal-Bat Aug 6, 2024
4810e17
docs(CHANGELOG): added change log to trace-context update
Metal-Bat Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,3 +1639,5 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3778](https://github.com/open-telemetry/opentelemetry-python/pull/3778))
- Fix license field in pyproject.toml files
([#3803](https://github.com/open-telemetry/opentelemetry-python/pull/3803))
- bump trace-context to e99a85d12df8c25c51ec1d5d234f20e918265b75
([#4109](https://github.com/open-telemetry/opentelemetry-python/pull/4109))
Copy link
Member

@emdneto emdneto Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should move this to the "# Unreleased" section at the beginning of the CHANGELOG.md file

8 changes: 4 additions & 4 deletions scripts/tracecontext-integration-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
#!/bin/sh
set -e
set -e
# hard-coding the git tag to ensure stable builds.
TRACECONTEXT_GIT_TAG="98f210efd89c63593dce90e2bae0a1bdcb986f51"
TRACECONTEXT_GIT_TAG="e99a85d12df8c25c51ec1d5d234f20e918265b75"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think won't be so to easy to point to the lastest :) There's a failing test test_tracestate_duplicated_keys.

In w3c/trace-context#477

The test_tracestate_duplicated_keys was broken, it demanded to drop
the whole tracestate when a duplicate key was found. This does not match
what the specification mandates in that situation. Instead,
implementations MAY remove the duplicates from tracestate or even leave
them in as-is.

# clone w3c tracecontext tests
mkdir -p target
rm -rf ./target/trace-context
git clone https://github.com/w3c/trace-context ./target/trace-context
cd ./target/trace-context && git checkout $TRACECONTEXT_GIT_TAG && cd -
# start example opentelemetry service, which propagates trace-context by
# start example opentelemetry service, which propagates trace-context by
# default.
python ./tests/w3c_tracecontext_validation_server.py 1>&2 &
EXAMPLE_SERVER_PID=$!
# give the app server a little time to start up. Not adding some sort
# of delay would cause many of the tracecontext tests to fail being
# unable to connect.
sleep 1
onshutdown()
onshutdown()
{
# send a sigint, to ensure
# it is caught as a KeyboardInterrupt in the
Expand Down
Loading